Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revitalize the kn-event jobs after Serverless 1.32 release #50051

Merged
merged 1 commit into from May 9, 2024
Merged

Revitalize the kn-event jobs after Serverless 1.32 release #50051

merged 1 commit into from May 9, 2024

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Mar 20, 2024

Changes

  1. Use serverless cluster pool for 4.15 jobs (related to [WIP] [TEST ONLY] Serverless: Use own cluster pool #50032)
  2. Remove old branches
  3. Add supported branches, according to https://access.redhat.com/product-life-cycles?product=Red%20Hat%20OpenShift%20Serverless

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2024
@openshift-ci-robot
Copy link
Contributor

@cardil, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto master: %!w(<nil>)
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@cardil cardil force-pushed the chore/update-kn-event-jobs branch from 7a9618a to 40f521d Compare March 20, 2024 13:39
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2024
@cardil
Copy link
Contributor Author

cardil commented Mar 20, 2024

/pj-rehearse more

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 22, 2024
@cardil cardil force-pushed the chore/update-kn-event-jobs branch from 40f521d to 4ffad96 Compare April 5, 2024 14:30
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 5, 2024
@openshift-ci-robot
Copy link
Contributor

@cardil, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from base revision of release repo: could not checkout worktree: '[git checkout b9f92e2b92c09b78d47c332c86dce7b981288b17]' failed with out:  and error exec: Stdout already set
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@cardil
Copy link
Contributor Author

cardil commented Apr 5, 2024

/pj-rehearse

@cardil cardil force-pushed the chore/update-kn-event-jobs branch from 4ffad96 to 98ba6d1 Compare April 5, 2024 14:50
@cardil cardil mentioned this pull request Apr 8, 2024
Merged
@cardil
Copy link
Contributor Author

cardil commented Apr 8, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@cardil: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@cardil
Copy link
Contributor Author

cardil commented Apr 8, 2024

/retest

@cardil
Copy link
Contributor Author

cardil commented Apr 8, 2024

/pj-rehearse pull-ci-openshift-knative-kn-plugin-event-release-1.11-images

@openshift-ci-robot
Copy link
Contributor

@cardil: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@cardil: job(s): pull-ci-openshift-knative-kn-plugin-event-release-1.11-images either don't exist or were not found to be affected, and cannot be rehearsed

@cardil
Copy link
Contributor Author

cardil commented Apr 8, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@cardil: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@cardil
Copy link
Contributor Author

cardil commented Apr 8, 2024

/pj-rehearse more

@openshift-ci-robot
Copy link
Contributor

@cardil: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@cardil
Copy link
Contributor Author

cardil commented Apr 10, 2024

/pj-rehearse pull-ci-openshift-knative-kn-plugin-event-release-next-415-e2e

@openshift-bot
Copy link
Contributor

@cardil: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@cardil
Copy link
Contributor Author

cardil commented Apr 10, 2024

/pj-rehearse pull-ci-openshift-knative-kn-plugin-event-release-1.13-415-e2e
/pj-rehearse pull-ci-openshift-knative-kn-plugin-event-release-1.11-415-e2e

@openshift-bot
Copy link
Contributor

@cardil: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-bot
Copy link
Contributor

@cardil: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

@dsimansk
Copy link
Contributor

/pj-rehearse pull-ci-openshift-knative-kn-plugin-event-release-1.13-415-e2e

@openshift-ci openshift-ci bot requested a review from mgencur May 8, 2024 19:05
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 9, 2024
@cardil
Copy link
Contributor Author

cardil commented May 9, 2024 •
edited

/pj-rehearse ack

Rehearsals already confirmed for previous commit 6258125, and the latest one 0b94b87 just merge upstream to fix OWNER file conflict.

See the PR's CI history

@openshift-ci-robot
Copy link
Contributor

@cardil: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 9, 2024
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 9, 2024
@cardil cardil force-pushed the chore/update-kn-event-jobs branch from de534b1 to 56e528d Compare May 9, 2024 11:08
@cardil cardil changed the title Update the kn-event jobs after Serverless 1.31 release Revitalize the kn-event jobs after Serverless 1.32 release May 9, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@cardil: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-knative-kn-plugin-event-release-1.11-415-e2e openshift-knative/kn-plugin-event presubmit Presubmit changed
pull-ci-openshift-knative-kn-plugin-event-release-1.11-415-images openshift-knative/kn-plugin-event presubmit Presubmit changed
pull-ci-openshift-knative-kn-plugin-event-release-1.11-415-unit openshift-knative/kn-plugin-event presubmit Presubmit changed
pull-ci-openshift-knative-kn-plugin-event-release-1.13-415-e2e openshift-knative/kn-plugin-event presubmit Presubmit changed
pull-ci-openshift-knative-kn-plugin-event-release-1.13-415-images openshift-knative/kn-plugin-event presubmit Presubmit changed
pull-ci-openshift-knative-kn-plugin-event-release-1.13-415-unit openshift-knative/kn-plugin-event presubmit Presubmit changed
pull-ci-openshift-knative-kn-plugin-event-release-1.14-415-e2e openshift-knative/kn-plugin-event presubmit Presubmit changed
pull-ci-openshift-knative-kn-plugin-event-release-1.14-415-images openshift-knative/kn-plugin-event presubmit Presubmit changed
pull-ci-openshift-knative-kn-plugin-event-release-1.14-415-unit openshift-knative/kn-plugin-event presubmit Presubmit changed
pull-ci-openshift-knative-kn-plugin-event-release-next-415-e2e openshift-knative/kn-plugin-event presubmit Presubmit changed
pull-ci-openshift-knative-kn-plugin-event-release-next-415-images openshift-knative/kn-plugin-event presubmit Presubmit changed
pull-ci-openshift-knative-kn-plugin-event-release-next-415-unit openshift-knative/kn-plugin-event presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@cardil
Copy link
Contributor Author

cardil commented May 9, 2024

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@cardil: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@cardil
Copy link
Contributor Author

cardil commented May 9, 2024

/pj-rehearse pull-ci-openshift-knative-kn-plugin-event-release-next-415-e2e pull-ci-openshift-knative-kn-plugin-event-release-1.14-415-e2e

@openshift-ci-robot
Copy link
Contributor

@cardil: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@cardil
Copy link
Contributor Author

cardil commented May 9, 2024

/pj-rehearse pull-ci-openshift-knative-kn-plugin-event-release-1.14-415-e2e pull-ci-openshift-knative-kn-plugin-event-release-next-415-e2e

@openshift-ci-robot
Copy link
Contributor

@cardil: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mgencur
Copy link
Contributor

mgencur commented May 9, 2024

/lgtm
/hold

Feel free to unhold if some of the rehearsals are note required.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cardil
Copy link
Contributor Author

cardil commented May 9, 2024

Those rehearsals were tested before. One of them failed cause of some infra failure. The other one failed due to an OOM error. That error was much more common, but since I raised memory to 6g I haven't seen it until now. I think I'll go with the current setting, and just raise it even more if it will be a real problem.

/unhold
/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@cardil: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 9, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 9, 2024

@cardil: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift-knative/kn-plugin-event/release-next/images 40f521d link unknown /pj-rehearse pull-ci-openshift-knative-kn-plugin-event-release-next-images
ci/rehearse/openshift-knative/kn-plugin-event/release-1.11/e2e-aws-ocp-415 40f521d link unknown /pj-rehearse pull-ci-openshift-knative-kn-plugin-event-release-1.11-e2e-aws-ocp-415
ci/rehearse/openshift-knative/kn-plugin-event/release-1.11/images 40f521d link unknown /pj-rehearse pull-ci-openshift-knative-kn-plugin-event-release-1.11-images
ci/rehearse/openshift-knative/kn-plugin-event/release-next/unit 40f521d link unknown /pj-rehearse pull-ci-openshift-knative-kn-plugin-event-release-next-unit
ci/rehearse/openshift-knative/kn-plugin-event/release-next/e2e-aws-ocp-415 40f521d link unknown /pj-rehearse pull-ci-openshift-knative-kn-plugin-event-release-next-e2e-aws-ocp-415
ci/rehearse/openshift-knative/kn-plugin-event/release-1.11/unit 40f521d link unknown /pj-rehearse pull-ci-openshift-knative-kn-plugin-event-release-1.11-unit
ci/rehearse/openshift-knative/kn-plugin-event/release-1.11/415-e2e-aws-ocp-415 4ffad96 link unknown /pj-rehearse pull-ci-openshift-knative-kn-plugin-event-release-1.11-415-e2e-aws-ocp-415
ci/prow/clusterimageset-validate 98ba6d1 link true /test clusterimageset-validate
ci/rehearse/openshift-knative/kn-plugin-event/release-next/415-e2e 56e528d link unknown /pj-rehearse pull-ci-openshift-knative-kn-plugin-event-release-next-415-e2e
ci/rehearse/openshift-knative/kn-plugin-event/release-1.14/415-e2e 56e528d link unknown /pj-rehearse pull-ci-openshift-knative-kn-plugin-event-release-1.14-415-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 7f308cd into openshift:master May 9, 2024
22 of 24 checks passed
@cardil cardil deleted the chore/update-kn-event-jobs branch May 9, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgencur mgencur mgencur left review comments

@danilo-gemoli danilo-gemoli Awaiting requested review from danilo-gemoli

@lance lance Awaiting requested review from lance

@dsimansk dsimansk Awaiting requested review from dsimansk

Assignees

@mgencur mgencur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
6 participants
@cardil @openshift-ci-robot @openshift-bot @dsimansk @mgencur @openshift-merge-robot